Nir Soffer has posted comments on this change. Change subject: tool: change configure verb logic. ......................................................................
Patch Set 1: (1 comment) Does this problem exist in current code? Please base this patch on current code, not on other patches that are debatable. Fixing real issue is more important that refactoring. http://gerrit.ovirt.org/#/c/34100/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 132: """ Line 133: args = _parse_args(*args) Line 134: Line 135: sys.stdout.write("\nChecking configuration status...\n\n") Line 136: configurer_to_trigger = [c for c in args.modules if filter_(c, args)] filter_ is not a good name, it does not filter anything (taking our some items from a list). A descriptive name would be should_configure() Line 137: Line 138: services = [] Line 139: for c in configurer_to_trigger: Line 140: for s in getattr(c, 'services', ()): -- To view, visit http://gerrit.ovirt.org/34100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I166fbae855ebff93ef84270f11b74f32fcc115c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
