Dima Kuznetsov has uploaded a new change for review.

Change subject: supervdsm: Add wait for SIGKILLed processes
......................................................................

supervdsm: Add wait for SIGKILLed processes

In present code, if _runAs code gets stuck or crashes unexpectedly, vdsm
would issue a SIGKILL but never wait on it.

Change-Id: Id97a578f77cf2c9a98788b4c2e29a799b2784fc3
Signed-off-by: Dima Kuznetsov <[email protected]>
---
M vdsm/supervdsmServer
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/34142/1

diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index eb912cd..ec9eb22 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -242,6 +242,8 @@
                 if e.errno != errno.ESRCH:
                     raise
 
+            # If we just killed a process or it died already, wait on it.
+            os.waitpid(proc.pid, os.WNOHANG)
             raise Timeout()
 
         res, err = pipe.recv()


-- 
To view, visit http://gerrit.ovirt.org/34142
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id97a578f77cf2c9a98788b4c2e29a799b2784fc3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to