Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: Add wait for SIGKILLed processes ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34142/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 246: Line 247: # If the child was already dead or just killed, wait on it, Line 248: # otherwise let zombiereaper take care of it. Line 249: if proc.pid != os.waitpid(proc.pid, os.WNOHANG): Line 250: zombiereaper.autoReapPID(proc.pid) > Thats make more sense - but if zombiereaper is watching this process, why t Because it could be that SIGCHLD already arrived, so we can collect it right away. There is still a little issue where child is killed between wait() and autoReapPID() and in that case it'll only get reaped when the next SIGCHLD arrives, but only using zombie-reaper does not solve it. Line 251: raise Timeout() Line 252: Line 253: res, err = pipe.recv() Line 254: pipe.send("Bye") -- To view, visit http://gerrit.ovirt.org/34142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id97a578f77cf2c9a98788b4c2e29a799b2784fc3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
