Shahar Havivi has posted comments on this change.

Change subject: PATCH: external VMs integration
......................................................................


Patch Set 5:

(2 comments)

No need to -1 yet..., this is still marked as draft ;)

http://gerrit.ovirt.org/#/c/33309/5//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: PATCH: external VMs integration
Line 8: 
Line 9: Added v2v module - added ability to list VMs from external source
Line 10: (non KVM) via libvirt.
> How could non-ovirt VMs be running on a host managed by Vdsm? We explictly 
This is a first patch as displayed first in this mail:
http://lists.ovirt.org/pipermail/devel/2014-September/008773.html

It will list (read only) existing VMs from external source such as VMWare, Xen.
Another feature that will be following this patch is the actual import of the 
VM to VDSM data domain.
Line 11: 
Line 12: The v2v module aims to add the ability to vdsm to integrate with
Line 13: external hypervisors and import VMs directly to storage domain.
Line 14: It will have an API for listing VMs with basic properties (such as 
name,


http://gerrit.ovirt.org/#/c/33309/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 96: 
Line 97:     auth = [[libvirt.VIR_CRED_AUTHNAME, libvirt.VIR_CRED_PASSPHRASE],
Line 98:             req, None]
Line 99:     try:
Line 100:         conn = libvirt.openAuth(uri, auth, 0)
> you should use libvirtconnection.get() instead of re-implementing it here.
Done
Line 101:     except libvirt.libvirtError as e:
Line 102:         logging.error(
Line 103:             'v2v.getExternalVMList: error connection to remove 
server: %s'
Line 104:             % e.message)


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to