Shahar Havivi has posted comments on this change.

Change subject: PATCH: external VMs integration
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/33309/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 96: 
Line 97:     auth = [[libvirt.VIR_CRED_AUTHNAME, libvirt.VIR_CRED_PASSPHRASE],
Line 98:             req, None]
Line 99:     try:
Line 100:         conn = libvirt.openAuth(uri, auth, 0)
> Done
Dan,
This is a different connection with different credentials and url,
libvirtconnection assume "qemu:///" and returns the already open connection.
Line 101:     except libvirt.libvirtError as e:
Line 102:         logging.error(
Line 103:             'v2v.getExternalVMList: error connection to remove 
server: %s'
Line 104:             % e.message)


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to