Francesco Romani has posted comments on this change. Change subject: vm: log exceptional monitor unresponsive case ......................................................................
Patch Set 3: Verified+1 verification: patch itself is quite trivial, code move + additional more restrictive conditional. Due to not very clear precondition, verification consisted in - run newly added tests (although testing specifics is not best practice...) to excercise the code paths - configured VDSM with very low command timeout (10s) , sent SIGSTOP to qemu and verified the log Thread-171::WARNING::2014-10-22 16:10:38,525::vm::5581::vm.Vm::(_setUnresponsiveIfTimeout) vmId=`79ffbf77-c5be-428b-85d5-fd0dc6e42ad7`::monitor become unresponsive (command timeout, age=10.6131989956) was present -- To view, visit http://gerrit.ovirt.org/33870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b88513d319d3f4530aa6d9f1b4a1c783b33347 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
