Dan Kenigsberg has posted comments on this change. Change subject: vm: log exceptional monitor unresponsive case ......................................................................
Patch Set 3: Code-Review-1 (2 comments) readability nits http://gerrit.ovirt.org/#/c/33870/3/tests/testlib.py File tests/testlib.py: Line 390: Line 391: sys.exit(not core.run(config=conf, testRunner=runner, argv=argv)) Line 392: Line 393: Line 394: def make_config(tunables): """create a vdsm.config.config clone, modified by tunables tunables is a list of (section, key, val) tuples""" Line 395: cfg = ConfigParser.ConfigParser() Line 396: vdsmconf.set_defaults(cfg) Line 397: for (section, key, value) in tunables: Line 398: cfg.set(section, key, value) Line 392: Line 393: Line 394: def make_config(tunables): Line 395: cfg = ConfigParser.ConfigParser() Line 396: vdsmconf.set_defaults(cfg) I find vdsm.config more readable. Line 397: for (section, key, value) in tunables: Line 398: cfg.set(section, key, value) -- To view, visit http://gerrit.ovirt.org/33870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b88513d319d3f4530aa6d9f1b4a1c783b33347 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
