Dan Kenigsberg has posted comments on this change. Change subject: config: warn about meaningless sampling windows ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33784/2//COMMIT_MSG Commit Message: Line 7: config: warn about meaningless sampling windows Line 8: Line 9: For some samplings, a window size different from Line 10: one was never supported, and exposed to configuration Line 11: by accident. Any value was silently ignored. Do we really need this prudence? These "window" configurable had never had any functional effect. Whomever changed them in vdsm.conf made a (harmless) mistake, but it is not Vdsm's job to warn him about it. Please drop them and forget they've ever existed - unless you can point to some user who may actually suffer from this. Line 12: Line 13: This patch: Line 14: Line 15: * set the defaults to '1' for relevant sample 'window's. -- To view, visit http://gerrit.ovirt.org/33784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a5a33da4194ff600824434d319c91b9dacc9f8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
