Francesco Romani has posted comments on this change. Change subject: config: warn about meaningless sampling windows ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33784/2//COMMIT_MSG Commit Message: Line 7: config: warn about meaningless sampling windows Line 8: Line 9: For some samplings, a window size different from Line 10: one was never supported, and exposed to configuration Line 11: by accident. Any value was silently ignored. > Do we really need this prudence? These "window" configurable had never had Works for me. Will move the window removal to another patch in this topic branch and abandon this patch. --- That said, the rationale behind this patch was/is that I believe that a software that unobtrusively warns about obviously wrong configuration/user input is friendlier and more pleasent to use than a silent one - even if this somehow brokes the unix tradition (perhaps) :) And this applies even to a system daemon like VDSM, which is already a quite complex beast to tune. So it is more about friendliness than prudence, I'm firmly at your side in the 'garbage in, garbage out' camp. Line 12: Line 13: This patch: Line 14: Line 15: * set the defaults to '1' for relevant sample 'window's. -- To view, visit http://gerrit.ovirt.org/33784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a5a33da4194ff600824434d319c91b9dacc9f8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
