Dan Kenigsberg has posted comments on this change. Change subject: caps: Additional ppc64 hardware information ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/33857/4/vdsm/ppc64HardwareInfo.py File vdsm/ppc64HardwareInfo.py: Line 27: with open(path) as f: Line 28: value = f.readline().rstrip('\0').replace(',', '') Line 29: return value Line 30: else: Line 31: return 'unavailable' In another patch, please replace the repeated string (where you can have a typo) with a CONSTANT. Line 32: Line 33: Line 34: @utils.memoized Line 35: def getHardwareInfoStructure(): -- To view, visit http://gerrit.ovirt.org/33857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f67a830740b64bc246f680f2c7a18a4293f4cc2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
