Ondřej Svoboda has posted comments on this change. Change subject: network: Inexistence of a network in libvirt should not be fatal to us ......................................................................
Patch Set 1: (1 comment) I am asking a question in the comment. http://gerrit.ovirt.org/#/c/34988/1/vdsm/network/api.py File vdsm/network/api.py: Line 689: if 'remove' in networkAttrs: Line 690: del networks[network] Line 691: del libvirt_nets[network] Line 692: _netinfo.updateDevices() Line 693: elif 'remove' in networkAttrs: Depending on options['_inRollback'] we could warn or raise the former exception. Line 694: logger.warning("Not deleting network {0!r}: it is unknown to " Line 695: "libvirtd".format(network)) Line 696: del networks[network] Line 697: else: -- To view, visit http://gerrit.ovirt.org/34988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6ae4b359d543b6e3ee560a5cb021e31d037c035 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
