Shahar Havivi has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 22: (3 comments) http://gerrit.ovirt.org/#/c/33309/22/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 324: vmList = args.get('vmList', []) Line 325: return API.Global().getVMList(False, vmList) Line 326: Line 327: Line 328: def Host_getExternalVMs_Call(api, args): > Why do we need this method. I do not see this method being used in command_ adding to command_info Line 329: """ Line 330: Return list of VMs from non-KVM source Line 331: """ Line 332: uri = args.get('uri') Line 349: """ Line 350: return [v['vmId'] for v in ret['vmList']] Line 351: Line 352: Line 353: def Host_getExternalVMs_Ret(ret): > Please add 'vmList' key to command_info. This method is not needed. Done Line 354: """ Line 355: Just return a list of VMs Line 356: """ Line 357: return ret['vmList'] http://gerrit.ovirt.org/#/c/33309/22/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3594: {'map': 'GuestDisksMappingMap', Line 3595: 'key': 'str', 'value': 'GuestDiskMappingInfo'} Line 3596: Line 3597: ## Line 3598: # @ExternalDiskInfo: > Looking at v2v.py it seems to me that some of the fields may be optional. C Done Line 3599: # Line 3600: # Disk information from external source Line 3601: # Line 3602: # @dev: guest device name (sda, sdb, etc) -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches