Francesco Romani has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 19: (1 comment) http://gerrit.ovirt.org/#/c/33309/19/tests/v2vTests.py File tests/v2vTests.py: Line 65: </devices> Line 66: </domain>""" Line 67: Line 68: Line 69: class LibvirtMock(object): > The reason I choose to make this classes here is the above domain xml that Makes sense. I'm fine with a TODO/FIXME (please add as reminder), but let's see (at low priority) if something comes out. Line 70: def close(self): Line 71: pass Line 72: Line 73: def listAllDomains(self): -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
