Allon Mureinik has posted comments on this change. Change subject: Live Merge: Proactively extend merge target volume ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35573/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1357: For internal volumes it is discovered by calling irs.getVolumeSize(). Line 1358: """ Line 1359: nextSize = (self.volExtensionChunk + Line 1360: ((curSize + constants.MEGAB - 1) / constants.MEGAB)) Line 1361: return min(nextSize, self.truesize) This seems generally true, regardless of live-merge scenarios. IIUC, any call extendDrivesIfNeeded will hit this caveat, so perhaps is worth having this change in a different patch that can easily be merges/reverted on its own right. Line 1362: Line 1363: @property Line 1364: def networkDev(self): Line 1365: try: -- To view, visit http://gerrit.ovirt.org/35573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d483f9dfe6e19a9f9fec84950bf2ea0c7ed7946 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
