Dan Kenigsberg has submitted this change and it was merged. Change subject: Live Merge: Proactively extend merge target volume ......................................................................
Live Merge: Proactively extend merge target volume Since libvirt is not yet providing the write watermark information for all volumes, we need to employ a workaround to support live merge on block-based storage. When starting a merge, we can request the base volume (merge target) to be extended to the size of the top volume (merge source) plus one chunk to accomodate active writing. This may cause some over-extension of the merge target volume but the upside is that the merge should complete without active monitoring. Future versions of oVirt will take advantage of an upcoming libvirt enhancement to report write watermarks for all volumes which will allow on-demand volume extension. Change-Id: I3d483f9dfe6e19a9f9fec84950bf2ea0c7ed7946 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155583 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: http://gerrit.ovirt.org/35614 Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-on: http://gerrit.ovirt.org/35573 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 26 insertions(+), 71 deletions(-) Approvals: Adam Litke: Verified Federico Simoncelli: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d483f9dfe6e19a9f9fec84950bf2ea0c7ed7946 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
