Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Make bootproto4 a boolean and rename it while it is still unused ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35984/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 492: 'dhcp4': bool(ipv4addr) and link.name in dhcp4, Line 493: 'mtu': str(link.mtu), Line 494: 'netmask': ipv4netmask} Line 495: if 'BOOTPROTO' not in info['cfg']: Line 496: info['cfg']['BOOTPROTO'] = info['dhcp4'] for legacy BOOTPROTO, we must keep reporting 'dhcp'. Line 497: return info Line 498: Line 499: Line 500: def _parseExpiryTime(expiryTime): -- To view, visit http://gerrit.ovirt.org/35984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29abc8db77f2ab12188d6007f072e16ccfd4b223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
