Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Make bootproto4 a boolean and rename it while it is still unused ......................................................................
Patch Set 8: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/35984/8/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1700: with vethIf() as (left, right): Line 1701: veth.setIP(left, IP_ADDRESS, IP_CIDR) Line 1702: veth.setLinkUp(left) Line 1703: with dnsmasqDhcp(left): Line 1704: dhcpv4 = True this is funny, but I understand that it's a preparation for a follow-up patch where dhcpv4 changes its value. Line 1705: bootproto = 'dhcp' Line 1706: network_name = NETWORK_NAME Line 1707: network = {network_name: {'nic': right, 'bridged': bridged, Line 1708: 'bootproto': bootproto, -- To view, visit http://gerrit.ovirt.org/35984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29abc8db77f2ab12188d6007f072e16ccfd4b223 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
