Yaniv Bronhaim has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap ......................................................................
Patch Set 3: Verified-1 (2 comments) http://gerrit.ovirt.org/#/c/35721/3/Makefile.am File Makefile.am: Line 28: vdsm \ Line 29: vdsm-tool \ Line 30: vdsm_hooks \ Line 31: vdsm_reg \ Line 32: vdsm_compat \ you can put that under RHEV flag? not sure, builder will just change the spec flag. I suspect this issue can't get solved nicely maybe alonbl has any suggestion Line 33: $(NULL) Line 34: Line 35: # The tests should be always last as they need the rest of the source to be Line 36: # prepared before running. http://gerrit.ovirt.org/#/c/35721/3/vdsm_compat/Makefile.am File vdsm_compat/Makefile.am: Line 20: Line 21: dist_vdsmpylib_PYTHON = \ Line 22: config.py \ Line 23: netinfo.py Line 24 this overrides the right modules when it shouldn't. we need to set it only on rhev_build? i see after installation those files installed under /usr/lib/python2.6/site-packages/vdsm/ instead of lib/vdsm code -- To view, visit http://gerrit.ovirt.org/35721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57754ce86f1f1e5978ff7e665c88218ee20d7ba3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
