Dan Kenigsberg has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap ......................................................................
Patch Set 4: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/35721/4/Makefile.am File Makefile.am: Line 28: vdsm \ Line 29: vdsm-tool \ Line 30: vdsm_hooks \ Line 31: vdsm_reg \ Line 32: vdsm_compat \ Please add to SUBDIRS only if RHEV. Line 33: $(NULL) Line 34: Line 35: # The tests should be always last as they need the rest of the source to be Line 36: # prepared before running. http://gerrit.ovirt.org/#/c/35721/4/vdsm.spec.in File vdsm.spec.in: Line 1273: %{python_sitelib}/%{vdsm_name}/vdscli.py* Line 1274: %{python_sitelib}/%{vdsm_name}/virtsparsify.py* Line 1275: %{python_sitelib}/%{vdsm_name}/xmlrpc.py* Line 1276: %{python_sitelib}/%{vdsm_name}/tool/__init__.py* Line 1277: #compat please limit to rhev_build Line 1278: %{_datadir}/%{vdsm_name}/config.py* Line 1279: %{_datadir}/%{vdsm_name}/netinfo.py* Line 1280: %if 0%{?with_systemd} Line 1281: %exclude %{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py* -- To view, visit http://gerrit.ovirt.org/35721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57754ce86f1f1e5978ff7e665c88218ee20d7ba3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
