Dan Kenigsberg has posted comments on this change. Change subject: fixing race while sampling interfaces ......................................................................
Patch Set 7: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36138/7/tests/samplingTests.py File tests/samplingTests.py: Line 127: finally: Line 128: try: Line 129: ipwrapper.linkDel(name) Line 130: except ipwrapper.IPRoute2Error: Line 131: pass why could this fail? Why would we want to hide this failure? Even if there's a good reason for this, it must be logged. Line 132: Line 133: Line 134: class InterfaceSampleTests(TestCaseBase): Line 135: NEW_INTERFACE = 'newinterface' Line 146: def testHostSampleReportsNewInterface(self): Line 147: hs_before = sampling.HostSample(os.getpid()) Line 148: interfaces_before = set(hs_before.interfaces.iterkeys()) Line 149: Line 150: with dummy(self.NEW_INTERFACE): please see my comment to line 157 in http://gerrit.ovirt.org/#/c/36138/5..7/tests/samplingTests.py Line 151: hs_after = sampling.HostSample(os.getpid()) Line 152: interfaces_after = set(hs_after.interfaces.iterkeys()) Line 153: interfaces_diff = interfaces_after - interfaces_before Line 154: self.assertEqual(interfaces_diff, set([self.NEW_INTERFACE])) -- To view, visit http://gerrit.ovirt.org/36138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059a5bfa4c140d88f512dc9a51d18f02956710de Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
