Dan Kenigsberg has posted comments on this change. Change subject: fixing race while sampling interfaces ......................................................................
Patch Set 9: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36138/9/tests/samplingTests.py File tests/samplingTests.py: Line 128: finally: Line 129: try: Line 130: ipwrapper.linkDel(name) Line 131: except ipwrapper.IPRoute2Error: Line 132: pass silently ignoring an exception requires a good excuse. Please add a comment here, stating that faultyGetLinks() is expected to have already removed the vlan device. Line 133: Line 134: Line 135: class InterfaceSampleTests(TestCaseBase): Line 136: def setUp(self): -- To view, visit http://gerrit.ovirt.org/36138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059a5bfa4c140d88f512dc9a51d18f02956710de Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
