Dan Kenigsberg has posted comments on this change. Change subject: explain more (udev) ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36268/1/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 279: self.log.debug("Creating rule %s: %r", ruleFile, rule) Line 280: rf.write(rule) Line 281: Line 282: @logDecorator Line 283: def appropriateVfioDevice(self, iommu_group): supply a means to remove the rule, too. Line 284: ruleFile = _UDEV_RULE_FILE_NAME % (iommu_group, iommu_group) Line 285: rule = 'KERNEL=="{}", SUBSYSTEM=="vfio" RUN+="{} {}:{} ' Line 286: ' /dev/vfio/{}"'.format(iommu_group, EXT_CHOWN, QEMU_PROCESS_USER, Line 287: QEMU_PROCESS_GROUP, iommu_group) Line 280: rf.write(rule) Line 281: Line 282: @logDecorator Line 283: def appropriateVfioDevice(self, iommu_group): Line 284: ruleFile = _UDEV_RULE_FILE_NAME % (iommu_group, iommu_group) please use your own file-naming scheme. it should be clear that they are distinct of the LUN ownership one. Line 285: rule = 'KERNEL=="{}", SUBSYSTEM=="vfio" RUN+="{} {}:{} ' Line 286: ' /dev/vfio/{}"'.format(iommu_group, EXT_CHOWN, QEMU_PROCESS_USER, Line 287: QEMU_PROCESS_GROUP, iommu_group) Line 288: with open(ruleFile, "w") as rf: -- To view, visit http://gerrit.ovirt.org/36268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieac8d58e01d7277e535a2101d522961816ea88eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
