Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: add dynamic udev rule creation for iommu groups
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/36268/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 314:         re_apprDevRule = "^" + _UDEV_RULE_FILE_PREFIX + 
"iommu_group_" + \
Line 315:             iommu_group + _UDEV_RULE_FILE_EXT + "$"
Line 316:         rules = [os.path.join(_UDEV_RULE_FILE_DIR, r) for r in
Line 317:                  os.listdir(_UDEV_RULE_FILE_DIR)
Line 318:                  if re.match(re_apprDevRule, r)]
no need for reg exp here.
Line 319:         fails = []
Line 320:         for r in rules:
Line 321:             try:
Line 322:                 self.log.debug("Removing rule %s", r)


-- 
To view, visit http://gerrit.ovirt.org/36268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieac8d58e01d7277e535a2101d522961816ea88eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to