Yeela Kaplan has posted comments on this change. Change subject: tool: change configurators from classes to modules. ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/34047/6/lib/vdsm/tool/configurators/certificates.py File lib/vdsm/tool/configurators/certificates.py: Line 53: Have you deleted validate on purpose? http://gerrit.ovirt.org/#/c/34047/6/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 167: Line 168: utils.unpersist(TARGET) Line 169: shutil.copyfile(packaged, TARGET) Line 170: utils.persist(TARGET) Line 171: Shouldn't these 3 lined be indented as well? Line 172: if (oldmod is not None and Line 173: oldmod != os.stat(TARGET).st_mode): Line 174: os.chmod(TARGET, oldmod) Line 175: reloadConfiguration() -- To view, visit http://gerrit.ovirt.org/34047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
