mooli tayer has posted comments on this change. Change subject: tool: change configurators from classes to modules. ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/34047/7/lib/vdsm/tool/configurators/sanlock.py File lib/vdsm/tool/configurators/sanlock.py: Line 54: sys.stderr.write(err) Line 55: if rc != 0: Line 56: raise RuntimeError("Failed to perform sanlock config.") Line 57: Line 58: > didn't we have removeConf for sanlock?? i recall we did.. I remember something too, but turns out we did not: http://gerrit.ovirt.org/#/c/20100/34/lib/vdsm/tool/configurator.py,cm Line 59: def isconfigured(): Line 60: """ Line 61: True if sanlock service is configured, False if sanlock service Line 62: requires a restart to reload the relevant supplementary groups. -- To view, visit http://gerrit.ovirt.org/34047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
