Ido Barkan has posted comments on this change. Change subject: teach addNetwork to add a netwrok to an existing bridge ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/35922/11/vdsm/network/api.py File vdsm/network/api.py: Line 317: if bridged and network in _netinfo.bridges: Line 318: net_ent_to_configure = net_ent.port Line 319: logging.info("Bridge %s already exists.", network) Line 320: # the bridge already exists and we attach a new underlying device to Line 321: # it. The we need to make sure that the bridge MTU configuration is > English: The we -> We Done Line 322: # updated. Line 323: configurator.configApplier.setIfaceMtu(network, mtu) Line 324: # we must also update the vms` tap devices (the bridge ports in this Line 325: # case) so that their MTU is synced with the bridge Line 320: # the bridge already exists and we attach a new underlying device to Line 321: # it. The we need to make sure that the bridge MTU configuration is Line 322: # updated. Line 323: configurator.configApplier.setIfaceMtu(network, mtu) Line 324: # we must also update the vms` tap devices (the bridge ports in this > ` -> ' ? Line 325: # case) so that their MTU is synced with the bridge Line 326: _update_bridge_ports_mtu(net_ent.name, mtu) Line 327: else: Line 328: net_ent_to_configure = net_ent Line 327: else: Line 328: net_ent_to_configure = net_ent Line 329: Line 330: if net_ent_to_configure is not None: Line 331: logging.info("Configuring device %s", net_ent_to_configure) > we're trying to reduce our log verbosity. isn't the name of the net_ent_to_ well, logs imply this: "Writing to file /etc/sysconfig/network-scripts/ifcfg-test-network configuration" or "/usr/sbin/ifdown test-network" so the name shows up but for me this log line was really missing. Line 332: net_ent_to_configure.configure(**options) Line 333: configurator.configureLibvirtNetwork(network, net_ent) Line 334: if hostQos is not None: Line 335: configurator.configureQoS(hostQos, net_ent) -- To view, visit http://gerrit.ovirt.org/35922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0df074c6c9d5f846748c2cff2cc14ba24305123b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
