Dan Kenigsberg has posted comments on this change. Change subject: teach addNetwork to add a netwrok to an existing bridge ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/35922/11/vdsm/network/api.py File vdsm/network/api.py: Line 320: # the bridge already exists and we attach a new underlying device to Line 321: # it. The we need to make sure that the bridge MTU configuration is Line 322: # updated. Line 323: configurator.configApplier.setIfaceMtu(network, mtu) Line 324: # we must also update the vms` tap devices (the bridge ports in this > ? you used the backtick instead the proper apostrophe. HUGE deal. Line 325: # case) so that their MTU is synced with the bridge Line 326: _update_bridge_ports_mtu(net_ent.name, mtu) Line 327: else: Line 328: net_ent_to_configure = net_ent -- To view, visit http://gerrit.ovirt.org/35922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0df074c6c9d5f846748c2cff2cc14ba24305123b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
