Dan Kenigsberg has posted comments on this change. Change subject: enable-rhev adds hooks and disable check on build ......................................................................
Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/36360/1/vdsm.spec.in File vdsm.spec.in: Line 19: %{!?rhev_build: %global rhev_build 0} Line 20: %if %{rhev_build} Line 21: %global rhev_build_config_opt --enable-rhev Line 22: %{!?enable_autotools:%define enable_autotools 1} Line 23: %global with_hooks 1 the commit message says one thing; the code does 3 others. Can you put some order into this? Could you split this up? Line 24: %else Line 25: # Default to skipping autoreconf. Distros can change just this one line Line 26: # (or provide a command-line override) if they backport any patches that Line 27: # touch configure.ac or Makefile.am. Line 28: %{!?enable_autotools:%define enable_autotools 0} Line 29: %endif Line 30: Line 31: # Skips check since rhel default repos lack pep8 and pyflakes Line 32: %if ! 0%{?rhel} && ! 0%{rhev_build} with this addition, building for el6 on koji would fail (as it is not a rhev_build, but pyflakes is missing). I don't think the addition has merit. Line 33: %{!?with_check:%global with_check 1} Line 34: %else Line 35: %{!?with_check:%global with_check 0} Line 36: %endif Line 76: License: GPLv2+ Line 77: Url: http://www.ovirt.org/wiki/Vdsm Line 78: %if 0%{?rhev_build} Line 79: # The source for this package was pulled from upstream's vcs. Line 80: # Use the following commands to generate the tarball: this comment is inappropriate in upstream. where's vdsm_relttag defined? Line 81: # git clone http://gerrit.ovirt.org/p/vdsm Line 82: # cd vdsm Line 83: # git reset --hard {vdsm_release} Line 84: # ./autogen.sh --system --enable-rhev -- To view, visit http://gerrit.ovirt.org/36360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9048c960882140c1f34655a107b275f03436782 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
