Yaniv Bronhaim has posted comments on this change. Change subject: enable-rhev adds hooks and disable check on build ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36360/1/vdsm.spec.in File vdsm.spec.in: Line 76: License: GPLv2+ Line 77: Url: http://www.ovirt.org/wiki/Vdsm Line 78: %if 0%{?rhev_build} Line 79: # The source for this package was pulled from upstream's vcs. Line 80: # Use the following commands to generate the tarball: > this comment is inappropriate in upstream. where's vdsm_relttag defined? as i assumed.. it was always copied from koji spec. removing it for good as it is redundant . Line 81: # git clone http://gerrit.ovirt.org/p/vdsm Line 82: # cd vdsm Line 83: # git reset --hard {vdsm_release} Line 84: # ./autogen.sh --system --enable-rhev -- To view, visit http://gerrit.ovirt.org/36360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9048c960882140c1f34655a107b275f03436782 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
