Dan Kenigsberg has posted comments on this change. Change subject: v2v: adding os support version for v2v ......................................................................
Patch Set 4: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36388/4/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3671: ## Line 3672: # @Host.getExternalVMs: Line 3673: # Line 3674: # Get information about the not-KVM virtual machines. Line 3675: # If the functionality is not supported - v2v.NotSupported this exception is not part of the API - I believe that the user of getExternalVMs would receive an errorcode 16 in this case. As such, I think that the text should simply say: this verb is not supported on el6. By the way: please explain in the commit message what exactly breaks on el6. Is it the version of guesttools? Line 3676: # exception raised Line 3677: # Line 3678: # @uri: libvirt connection uri Line 3679: # http://gerrit.ovirt.org/#/c/36388/4/vdsm/v2v.py File vdsm/v2v.py: Line 19: import xml.etree.ElementTree as ET Line 20: from contextlib import closing Line 21: import libvirt Line 22: Line 23: import caps should be imported after "logging". Come to think of it - so should have "libvirt". Line 24: import logging Line 25: from vdsm import libvirtconnection Line 26: Line 27: -- To view, visit http://gerrit.ovirt.org/36388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99a343a9634a90502feff46caed2c05b6af93ad5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
