Nir Soffer has posted comments on this change. Change subject: v2v: adding os support version for v2v ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36388/4/vdsm/v2v.py File vdsm/v2v.py: Line 39: Line 40: Line 41: def get_external_vms(uri, username, password): Line 42: if not supported(): Line 43: raise NotSupported('v2v is not supported in current os version') Dan suggested to return here "unexpected" error (code 16), but I think that "noimpl" is more correct: return errCode["noimpl"] And we can delete the NotSupported exception. Line 44: Line 45: conn = libvirtconnection.open_connection(uri=uri, Line 46: username=username, Line 47: passwd=password) -- To view, visit http://gerrit.ovirt.org/36388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99a343a9634a90502feff46caed2c05b6af93ad5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
