Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: change configurators from classes to modules. ......................................................................
tool: change configurators from classes to modules. Currently we have: |-- configurators package | |-- certificates.py module | | |-- ModuleConfigure class | |-- libvirt.py module | | |-- ModuleConfigure class | |-- sanlock.py module | | |-- ModuleConfigure class I am suggesting to make this flatter: |-- configurators package | |-- certificates.py module | |-- libvirt.py module | |-- sanlock.py module Defaults moved from the less visible __init__.py to the configurators consumer. What was once named a ModuleConfigurer is now called a configurator module. Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580 Signed-off-by: Mooli Tayer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/34047 Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/certificates.py M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/configurators/multipath.py M lib/vdsm/tool/configurators/sanlock.py M lib/vdsm/tool/configurators/sebool.py M tests/toolTests.py 8 files changed, 834 insertions(+), 875 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
