Dan Kenigsberg has posted comments on this change. Change subject: Add tests for getAllVolumes ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36589/2/tests/fileSDTests.py File tests/fileSDTests.py: Line 58: def __init__(self, glob=None): Line 59: self.glob = glob Line 60: Line 61: Line 62: class GetAllVolumesTests(TestCaseBase): please consider placing the new tests in the too-thin tests/getAllVolumesTests.py Line 63: Line 64: MOUNTPOINT = "/rhev/data-center/%s" % uuid.uuid4() Line 65: SD_UUID = str(uuid.uuid4()) Line 66: IMAGES_DIR = os.path.join(MOUNTPOINT, SD_UUID, sd.DOMAIN_IMAGES) -- To view, visit http://gerrit.ovirt.org/36589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43d8970ffc9bb8ee7679232ff3ee95cb2cda36c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
