Federico Simoncelli has posted comments on this change. Change subject: Add tests for getAllVolumes ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/36589/3/tests/fileSDTests.py File tests/fileSDTests.py: Line 79: os.path.join(self.IMAGES_DIR, "image-2", "volume-4.meta"), Line 80: os.path.join(self.IMAGES_DIR, "image-2", "volume-5.meta"), Line 81: os.path.join(self.IMAGES_DIR, "image-3", "volume-6.meta"), Line 82: ])) Line 83: print oop.glob.files No need to print. Line 84: dom = TestingFileStorageDomain(self.SD_UUID, self.MOUNTPOINT, oop) Line 85: res = dom.getAllVolumes() Line 86: Line 87: # These volumes should have parent uuid, but the implementation does Line 101: os.path.join(self.IMAGES_DIR, "image-1", "volume-1.meta"), Line 102: os.path.join(self.IMAGES_DIR, "image-1", "volume-2.meta"), Line 103: os.path.join(self.IMAGES_DIR, "image-1", "volume-3.meta"), Line 104: os.path.join(self.IMAGES_DIR, "image-2", "volume-1.meta"), Line 105: os.path.join(self.IMAGES_DIR, "image-2", "volume-4.meta"), Let's add an image-3 not based on the template to make sure that it's not listed. Line 106: ])) Line 107: dom = TestingFileStorageDomain(self.SD_UUID, self.MOUNTPOINT, oop) Line 108: res = dom.getAllVolumes() Line 109: Line 150: Line 151: start = time.time() Line 152: res = dom.getAllVolumes() Line 153: elapsed = time.time() - start Line 154: print "%f seconds" % elapsed No need to print. Line 155: Line 156: # This task should take no time using decent algorithm, using one Line 157: # second to make sure it will not fail on a overloaded test slave. -- To view, visit http://gerrit.ovirt.org/36589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43d8970ffc9bb8ee7679232ff3ee95cb2cda36c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
