Nir Soffer has uploaded a new change for review.

Change subject: fileUtils: Remove bugus warning when creating directories
......................................................................

fileUtils: Remove bugus warning when creating directories

Lot of storage code uses fileUtils.createdir() to create directories,
causing bogus warnings when the directory already exists. These warnings
not only make it harder to debug real issues, but make users worry about
non-exisiting problems and generaly waste everyone time.

The warning was converted to debug message that should be helpful for
debugging.

Change-Id: I7800b860eb81334b63abefcca9a21a552331458f
Bug-Url: https://bugzilla.redhat.com/1129587
Signed-off-by: Nir Soffer <[email protected]>
---
M vdsm/storage/fileUtils.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/36764/1

diff --git a/vdsm/storage/fileUtils.py b/vdsm/storage/fileUtils.py
index 3c1e5bb..95f7682 100644
--- a/vdsm/storage/fileUtils.py
+++ b/vdsm/storage/fileUtils.py
@@ -146,7 +146,7 @@
         if e.errno != errno.EEXIST:
             raise
         else:
-            log.warning("Dir %s already exists", dirPath)
+            log.debug("Using existing directory: %s", dirPath)
             if mode is not None:
                 statinfo = os.stat(dirPath)
                 curMode = statinfo[stat.ST_MODE]


-- 
To view, visit http://gerrit.ovirt.org/36764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to