Dan Kenigsberg has posted comments on this change. Change subject: fileUtils: Remove useless warning when creating directories ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36764/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-01-12 00:59:14 +0200 Line 6: Line 7: fileUtils: Remove useless warning when creating directories Line 8: Line 9: Lot of storage code uses fileUtils.createdir() to create directories, Why do we call fileUtils.createdir() despite the pre-existence of the directory? The warning can be useful in order to track these sloppy pieces of code and fix them. The fact that we have not done that yet does not make the warning "useless". There's use for mkdir(2)'s EEXIST errno. Can you list flows that reproduce this warning on a normal flow? They should be added to http://www.ovirt.org/Vdsm_TODO . With such a list, and a nicer statement such as: "right now we have no resources to solve the problems exposed by the warning", we can consider reducing the "warning" to "info". Line 10: causing useless warnings when the directory already exists. These Line 11: warnings not only make it harder to debug real issues, but make users Line 12: worry about non-existing problems and generally waste everyone time. Line 13: -- To view, visit http://gerrit.ovirt.org/36764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
