Martin Polednik has posted comments on this change. Change subject: hostdev: implement numvfs changing ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/36216/3/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 200: return setupNetworks(networks, bondings, **options) Line 201: Line 202: @logDecorator Line 203: def changeNumvfs(self, device_name, numvfs): Line 204: with open('/sys/bus/pci/devices/{}/sriov_numvfs'.format( > We should make sure that the VF number is persisted and is re-applied after Since Alex indicated that no support for such functionality exists and implementing would take insanely long time (considering kernel/systemd), we've discussed with Michal sending request when host becomes available in order to keep persistence. You could then ifdown/ifup interfaces that require ifcfg scripts. Line 205: device_name), 'w', 0) as f: Line 206: f.write('0') Line 207: f.write(str(numvfs)) Line 208: Line 203: def changeNumvfs(self, device_name, numvfs): Line 204: with open('/sys/bus/pci/devices/{}/sriov_numvfs'.format( Line 205: device_name), 'w', 0) as f: Line 206: f.write('0') Line 207: f.write(str(numvfs)) > which race to you refer to? Two Engines calling changeNumvfs at once? Also asking about the race: 2 engines-1 vdsm is unsupported configuration. Should you mean other race, I was thinking about obtaining exclusive lock via fnctl syscall (actually fnctl.lockf). Line 208: Line 209: def _runAs(self, user, groups, func, args=(), kwargs={}): Line 210: def child(pipe): Line 211: res = ex = None -- To view, visit http://gerrit.ovirt.org/36216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110972fa12ffb7f5996fe46135644b5c0a11743b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
