Francesco Romani has posted comments on this change. Change subject: hostdev: implement numvfs changing ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36216/3/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 203: def changeNumvfs(self, device_name, numvfs): Line 204: with open('/sys/bus/pci/devices/{}/sriov_numvfs'.format( Line 205: device_name), 'w', 0) as f: Line 206: f.write('0') Line 207: f.write(str(numvfs)) > Also asking about the race: 2 engines-1 vdsm is unsupported configuration. Yep, I was probably being oversuspicious because noone else but VDSM is supposed to touch this file (otherwise it is unsupported configuration) and only one Engine at time is supposed to issue commands to VDSM, so sorry for the noise and let's ignore my remark. Line 208: Line 209: def _runAs(self, user, groups, func, args=(), kwargs={}): Line 210: def child(pipe): Line 211: res = ex = None -- To view, visit http://gerrit.ovirt.org/36216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110972fa12ffb7f5996fe46135644b5c0a11743b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
