Nir Soffer has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/36263/8/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3635: # @dev: #optional guest device name (sda, sdb, etc) Line 3636: # Line 3637: # @alias: #optional device path (file path) Line 3638: # Line 3639: # @truesize: #optional device size in bytes > Please suggest name I don't think that the name is the issue here - it is picking the right term used in other apis, that match what libvirt returns. Line 3640: # Line 3641: # Since: 4.17.0 Line 3642: ## Line 3643: {'type': 'ExternalDiskInfo', Line 3640: # Line 3641: # Since: 4.17.0 Line 3642: ## Line 3643: {'type': 'ExternalDiskInfo', Line 3644: 'data': {'*dev': 'str', '*alias': 'str', '*truesize': 'str'}} > Done size must be string since the value is greater then int32_t, and xmlrpc cannot use such integers. Check how the same value is defined in the schema. Line 3645: Line 3646: ## Line 3647: # @ExternalNetworkInfo: Line 3648: # -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
