Shahar Havivi has posted comments on this change. Change subject: v2v: add volume size to disk info ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/36263/11/tests/v2vTests.py File tests/v2vTests.py: Line 78: def storageVolLookupByPath(self, name): Line 79: return LibvirtMock.Volume() Line 80: Line 81: class Volume(object): Line 82: def info(item): > 'self' is missing thanks, I just talk to Dan and we did address this issues, will send a new patch Line 83: return [0, 0] Line 84: Line 85: Line 86: def hypervisorConnect(uri, username, passwd): -- To view, visit http://gerrit.ovirt.org/36263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
