Dan Kenigsberg has submitted this change and it was merged. Change subject: Add tests for getAllVolumes ......................................................................
Add tests for getAllVolumes Profiling show that FileStorageDomain.getAllVolumes is too slow, taking more than 30% of cpu time when starting or recoverting 20 vms with 3000 disks on NFS storage domain. Each call in this setup took 44 seconds of cpu time. This patch adds tests documenting the somewhat surprizing behavior of getAllVolumes to make sure we do not break it in the next patch. Change-Id: Ia43d8970ffc9bb8ee7679232ff3ee95cb2cda36c Relates-To: https://bugzilla.redhat.com/1177634 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/36589 Reviewed-by: Federico Simoncelli <[email protected]> --- M tests/Makefile.am A tests/fileSDTests.py 2 files changed, 160 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia43d8970ffc9bb8ee7679232ff3ee95cb2cda36c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
