Federico Simoncelli has posted comments on this change. Change subject: Handle iscsi iface.net_ifacename for existing iface ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/35976/4/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 166: continue Line 167: Line 168: if netIfaceName is not None: Line 169: if not _updateIfaceNameIfNeeded(iface, netIfaceName) and \ Line 170: netIfaceName != iface.netIfaceName: We prefer the parenthesis and a slightly different indentation (for readability). if (not _updateIfaceNameIfNeeded(iface, netIfaceName) and netIfaceName != iface.netIfaceName): logging.error(...) (That should pass pep8 just fine) Sorry for bothering you again but I really think that it will make the readability much better. Line 171: logging.error('iSCSI netIfaceName coming from engine [%s] ' Line 172: 'is different from iface.net_ifacename ' Line 173: 'present on the system [%s]. Aborting iscsi ' Line 174: 'iface [%s] configuration.' % -- To view, visit http://gerrit.ovirt.org/35976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18c2b92a75ee3bcbbcc546e2bfa4f133a5f9ad22 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
