Dan Kenigsberg has submitted this change and it was merged. Change subject: Handle iscsi iface.net_ifacename for existing iface ......................................................................
Handle iscsi iface.net_ifacename for existing iface Using a new version of engine which provides netIfaceName as an iscsi connection option, hypervisor has to properly handle this option. - For non-existent iscsi iface, nothing changes. We will create the device using the netIfaceName coming from engine. - For already present iscsi iface: * If iface.net_ifacename is empty, we update iface using the value coming from engine. * If iface.net_ifacename has a value and the value is different from the netIfaceName coming from engine, we raise an exception and skip the iface configuration. Manual intervention will be needed. Change-Id: I18c2b92a75ee3bcbbcc546e2bfa4f133a5f9ad22 Signed-off-by: Amador Pahim <[email protected]> Reviewed-on: http://gerrit.ovirt.org/35976 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/storage/hsm.py M vdsm/storage/iscsiadm.py 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Amador Pahim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c2b92a75ee3bcbbcc546e2bfa4f133a5f9ad22 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
