Dan Kenigsberg has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing ifaces using NM_CONTROLLED=no ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/37037/3/tests/functional/networkmanager.py File tests/functional/networkmanager.py: Line 49: ifcfg.write('DEVICE={0}\n' Line 50: 'NM_CONTROLLED=no\n'.format(iface)) Line 51: rc, _, _ = execCmd([_NM_CLI_BINARY.cmd, 'conn', 'load', ifcfg_path]) Line 52: if rc: Line 53: raise SkipTest('Failed to unmanage ' + iface) please include out and err to make the debgger life easier. Line 54: Line 55: Line 56: def _restore(iface): Line 57: ifcfg_path = netinfo.NET_CONF_PREF + iface Line 54: Line 55: Line 56: def _restore(iface): Line 57: ifcfg_path = netinfo.NET_CONF_PREF + iface Line 58: execCmd([_NM_CLI_BINARY.cmd, 'conn', 'delete', iface]) check rc and write out/err to log in case of error. -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
