Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing ifaces using NM_CONTROLLED=no ......................................................................
Patch Set 3: (1 comment) Further comments. http://gerrit.ovirt.org/#/c/37037/3/tests/functional/veth.py File tests/functional/veth.py: Line 27: import networkmanager Line 28: Line 29: Line 30: @contextmanager Line 31: def create(prefix='veth_', max_length=15): Dan also suggested to keep the original semantics and separate functionality of create(), and to give the context manager a more suitable name. Line 32: """ Line 33: Yield a pair of veth devices. This assumes root privileges (currently Line 34: required by all tests anyway). Line 35: -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
