Nir Soffer has posted comments on this change. Change subject: vm: LSM between mixed domain types ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/37095/15/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1471: self.pause(pauseCode='EOTHER') Line 1472: raise ImprobableResizeRequestError(msg) Line 1473: Line 1474: self.log.debug("physical: %d alloc: %d watermarkLimit: %d", Line 1475: physical, alloc, drive.watermarkLimit) This was useful for initial debugging, but we can probably remove this. Line 1476: if physical - alloc < drive.watermarkLimit: Line 1477: return True Line 1478: return False Line 1479: Line 3497: dstxml = self._diskReplicaXML(srcDrive, dstDisk["blockDev"], Line 3498: dstDiskCopy["path"]) Line 3499: flags = (libvirt.VIR_DOMAIN_BLOCK_COPY_SHALLOW | Line 3500: libvirt.VIR_DOMAIN_BLOCK_COPY_REUSE_EXT) Line 3501: self._dom.blockCopy(srcDrive.name, dstxml.toxml(), flags=flags) Should extract _startBlockCopy() method using blockCopy if available or blockRebase if not. Line 3502: except Exception: Line 3503: self.log.exception("Unable to start the replication" Line 3504: " for %s to %s", Line 3505: srcDrive.name, dstDiskCopy) -- To view, visit http://gerrit.ovirt.org/37095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94585d9a963b2734f76f6a82f8fbb4609665224c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
