Nir Soffer has posted comments on this change. Change subject: vm: LSM between mixed domain types ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/37095/15/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1420: if not drive.blockDev: Line 1421: replica = drive.diskReplicate Line 1422: res = self.cif.irs.getVolumeSize( Line 1423: replica["domainID"], replica["poolID"], replica["imageID"], Line 1424: replica["volumeID"]) Separate patch: extract to getDriveVolumeSize - returning ints instead of strings - raising DriveVolumeError when status code is nonzero Line 1425: if res['status']['code'] != 0: Line 1426: self.log.error( Line 1427: "Error getting size for volume %s domain %s", Line 1428: replica["volumeID"], replica["domainID"]) Line 3552: driverAttrs['error_policy'] = 'stop' Line 3553: Line 3554: disk.appendChildWithArgs('driver', **driverAttrs) Line 3555: Line 3556: return disk Separate patch: refactor Drive so it can return this xml. Line 3557: Line 3558: def diskReplicateFinish(self, srcDisk, dstDisk): Line 3559: try: Line 3560: srcDrive = self._findDriveByUUIDs(srcDisk) -- To view, visit http://gerrit.ovirt.org/37095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94585d9a963b2734f76f6a82f8fbb4609665224c Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
