Francesco Romani has posted comments on this change. Change subject: hostdev: add support for reporting usb addresses ......................................................................
Patch Set 6: (1 comment) seems ok, a question inside. http://gerrit.ovirt.org/#/c/35785/6/vdsm/hostdev.py File vdsm/hostdev.py: Line 74: also doing sysfs lookups for sr-iov related information Line 75: """ Line 76: address_parser = {'pci': _parse_pci_address, Line 77: 'scsi': _parse_scsi_address, Line 78: 'usb_device': _parse_usb_address} why 'usb_device' and not just 'usb'? Line 79: Line 80: params = {} Line 81: Line 82: devXML = etree.fromstring(device_xml) -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
