Frank Kobzik has uploaded a new change for review. Change subject: vdsm: Fix return value of _setTicketForGraphicDev ......................................................................
vdsm: Fix return value of _setTicketForGraphicDev Invoking VM.updateDevice method via json api expects result to contain vmList attribute, however, this method doesn't always contain it in case of updating graphics device. This patch adds the attribute. Change-Id: I08814006b413a7f213561e1884166af4d0d6c8ae Signed-off-by: Frantisek Kobzik <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/37484/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 4954c87..9cbb82a 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2513,10 +2513,13 @@ def _updateGraphicsDevice(self, params): graphics = self._findGraphicsDeviceXMLByType(params['graphicsType']) + if graphics: - return self._setTicketForGraphicDev( + res = self._setTicketForGraphicDev( graphics, params['password'], params['ttl'], params['existingConnAction'], params['params']) + res.update({'vmList': self.status()}) + return res else: return errCode['updateDevice'] -- To view, visit http://gerrit.ovirt.org/37484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08814006b413a7f213561e1884166af4d0d6c8ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
