Francesco Romani has posted comments on this change. Change subject: vdsm: Fix return value of _setTicketForGraphicDev ......................................................................
Patch Set 1: Code-Review-1 (3 comments) My fault, relic of time on which schema wasn't carefully controlled as it is today. But mostly my fault. Looks OK conceptually, but we need to fix a couple of things. http://gerrit.ovirt.org/#/c/37484/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2512: conf['portMirroring'] = networks Line 2513: Line 2514: def _updateGraphicsDevice(self, params): Line 2515: graphics = self._findGraphicsDeviceXMLByType(params['graphicsType']) Line 2516: I like this, but it is unrelated. Line 2517: if graphics: Line 2518: res = self._setTicketForGraphicDev( Line 2519: graphics, params['password'], params['ttl'], Line 2520: params['existingConnAction'], params['params']) Line 2514: def _updateGraphicsDevice(self, params): Line 2515: graphics = self._findGraphicsDeviceXMLByType(params['graphicsType']) Line 2516: Line 2517: if graphics: Line 2518: res = self._setTicketForGraphicDev( let's call this 'response' instead of 'res' Line 2519: graphics, params['password'], params['ttl'], Line 2520: params['existingConnAction'], params['params']) Line 2521: res.update({'vmList': self.status()}) Line 2522: return res Line 2517: if graphics: Line 2518: res = self._setTicketForGraphicDev( Line 2519: graphics, params['password'], params['ttl'], Line 2520: params['existingConnAction'], params['params']) Line 2521: res.update({'vmList': self.status()}) please let's use if res['status']['code'] == 0: res['vmList'] = self.status() Line 2522: return res Line 2523: else: Line 2524: return errCode['updateDevice'] Line 2525: -- To view, visit http://gerrit.ovirt.org/37484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08814006b413a7f213561e1884166af4d0d6c8ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
